Review Request 119868: KConfig add DirectoryType support

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119868/#review64952
-----------------------------------------------------------


We have never needed this until now because we can recognize such files by their name... So while I'm not opposed to this, I wonder, why not use if (u.fileName() == ".directory") in KDesktopFileActions (RR 119869) -- which will also make it work with existing .directory files that got created without a Type=Directory entry?


src/core/kdesktopfile.h
<https://git.reviewboard.kde.org/r/119868/#comment45381>

    wheter -> whether
    an -> a



src/core/kdesktopfile.h
<https://git.reviewboard.kde.org/r/119868/#comment45382>

    @since 5.2


- David Faure


On Aug. 20, 2014, 10:34 p.m., Maarten De Meyer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119868/
> -----------------------------------------------------------
> 
> (Updated Aug. 20, 2014, 10:34 p.m.)
> 
> 
> Review request for KDE Frameworks, kdelibs and Frank Reininghaus.
> 
> 
> Repository: kconfig
> 
> 
> Description
> -------
> 
> Add a hasDirectoryType method to KDesktopFile.
> This is required for review request [119869](https://git.reviewboard.kde.org/r/119869/)
> 
> 
> Diffs
> -----
> 
>   src/core/kdesktopfile.h 2190051 
>   src/core/kdesktopfile.cpp 6278309 
> 
> Diff: https://git.reviewboard.kde.org/r/119868/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Maarten De Meyer
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140821/c75eba8a/attachment.html>