Review Request 119871: Fix rendering glitches of TabButtons due to inconsistent option->state settings

[Hugo Pereira Da Costa]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119871/
-----------------------------------------------------------

(Updated Aug. 20, 2014, 8:21 p.m.)


Review request for KDE Frameworks, Christoph Feck, Gilles Caulier, and Marko Käning.


Changes
-------

Marko, if this indeed fixes 296810, does it make sense to backport it to kdelibs4?


Repository: kwidgetsaddons


Description
-------

With both breeze and oxygen, the multitabbar tab buttons had visual glitches when pressed/hovered/focused, etc. 

See for instance Kate.

This is due to an inconsistency in the option->state set in initStyleOption.
State_AutoRaise is passed in mouse-over mode, and not passed in normal mode.
Now, 
1/ styles might not have the same margins, offsets, etc. for autoraised and flat toolbuttons
2/ the mouseover state might not be the same at the time ::sizeHint is called and at the time ::paintevent is called.
So you can get random rendering issues, due to typically the widget size not being what is expected by the style to paint.

Easy fix is to always set the state as autoraise (which makes sense for this 'custom' toolbar. 

PS: Christoph, I'd like to add groups instead of reviewers, but am really confused about how this works in kf5 days ... 

PS2: I can try add screenshots if necessary


Diffs
-----

  src/kmultitabbar.cpp 0420bec 

Diff: https://git.reviewboard.kde.org/r/119871/diff/


Testing
-------

With oxygen, breeze and fusion.
No more issues


Thanks,

Hugo Pereira Da Costa

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140820/1cc6836f/attachment.html>