Review Request 119846: qtcontrols port for checkbox and radiobutton

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119846/#review64882
-----------------------------------------------------------



src/declarativeimports/plasmacomponents/qml/styles/CheckBoxStyle.qml
<https://git.reviewboard.kde.org/r/119846/#comment45346>

    Good question.
    
    I think it is needed to set background to something otherwise it will use the one in the Base style.



src/declarativeimports/plasmacomponents/qml/styles/CheckBoxStyle.qml
<https://git.reviewboard.kde.org/r/119846/#comment45348>

    checked isn't a boolean, it's an enum of the checked, partial, unchecked.



src/declarativeimports/plasmacomponents/qml/styles/RadioButtonStyle.qml
<https://git.reviewboard.kde.org/r/119846/#comment45347>

    Can/should this be fixed inside the SVGs?
    
    Otherwise we're doing breeze hacks at a code level, a themer who creates both as rectangles will get one inexplicably larger


- David Edmundson


On Aug. 19, 2014, 5:21 p.m., Marco Martin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119846/
> -----------------------------------------------------------
> 
> (Updated Aug. 19, 2014, 5:21 p.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> this ports checkbox and radiobuttons (and switch that at least on desktop formfactor is just an alias for checkboxes) to qtcontrols and adds the corresponding styles
> 
> 
> Diffs
> -----
> 
>   src/declarativeimports/plasmacomponents/qml/CheckBox.qml 5e98d11 
>   src/declarativeimports/plasmacomponents/qml/RadioButton.qml 00a1bbf 
>   src/declarativeimports/plasmacomponents/qml/Switch.qml d0608f9 
>   src/declarativeimports/plasmacomponents/qml/styles/CheckBoxStyle.qml PRE-CREATION 
>   src/declarativeimports/plasmacomponents/qml/styles/RadioButtonStyle.qml PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/119846/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140819/d7e73a3d/attachment.html>