Review Request 119781: Port TextArea to QtControls

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119781/#review64717
-----------------------------------------------------------

Ship it!


See comments first.


src/declarativeimports/plasmacomponents/qml/styles/TextAreaStyle.qml
<https://git.reviewboard.kde.org/r/119781/#comment45271>

    this shouldn't be needed



src/declarativeimports/plasmacomponents/qml/styles/TextAreaStyle.qml
<https://git.reviewboard.kde.org/r/119781/#comment45272>

    we don't need the 
    
    "property font " stuff.



src/declarativeimports/plasmacomponents/qml/styles/TextAreaStyle.qml
<https://git.reviewboard.kde.org/r/119781/#comment45270>

    These two can die


- David Edmundson


On Aug. 18, 2014, 9:25 a.m., Marco Martin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119781/
> -----------------------------------------------------------
> 
> (Updated Aug. 18, 2014, 9:25 a.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> This ports TextArea to Qtcontrols, all old properties/functions work (except for errorHighlight that was a stub already)
> moves also the scrollview style to make everything in the same place. (needs to be more complete still before becoming a proper import)
> 
> 
> Diffs
> -----
> 
>   src/declarativeimports/plasmacomponents/qml/TextArea.qml 3f68934 
>   src/declarativeimports/plasmacomponents/qml/styles/ScrollViewStyle.qml PRE-CREATION 
>   src/declarativeimports/plasmacomponents/qml/styles/TextAreaStyle.qml PRE-CREATION 
>   src/declarativeimports/plasmaextracomponents/qml/ScrollArea.qml 3818142 
>   src/declarativeimports/plasmaextracomponents/qml/styles/ScrollViewStyle.qml cb0b190 
> 
> Diff: https://git.reviewboard.kde.org/r/119781/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140818/6c1398e6/attachment.html>