Review Request 119781: Port TextArea to QtControls

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119781/#review64672
-----------------------------------------------------------



src/declarativeimports/plasmacomponents/qml/styles/TextAreaStyle.qml
<https://git.reviewboard.kde.org/r/119781/#comment45230>

    I can see why you're doing this but I think this approach is a bit dangerous, it means we constantly have to match our propoerties with upstream's. 
    
    If 5.4 introduces a new property to TextAreaStyle, we won't use the default implementation but instead try to use properties that doesn't exist which could potentially explode.
    
    What might work is:
    
    QtQuickControls.TextAreaStyle
    {
        ScrollViewStyle {
           id: svs
        }
        
        frame: svs.frame
        scrollBarBackground: svs.scrollBarBackground
        handle: svs.handle
        (and so on)
        
        textColor: theme...whatever
    
    }
    Then we don't need to redeclare the properties and have the cursorHandle, selectionHandle etc.
    
    There's also an abandoned upstream review request to make Scrollbars a single component which will solve most the duplication. We could try and help get that finished.


- David Edmundson


On Aug. 14, 2014, 11:10 a.m., Marco Martin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119781/
> -----------------------------------------------------------
> 
> (Updated Aug. 14, 2014, 11:10 a.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> This ports TextArea to Qtcontrols, all old properties/functions work (except for errorHighlight that was a stub already)
> moves also the scrollview style to make everything in the same place. (needs to be more complete still before becoming a proper import)
> 
> 
> Diffs
> -----
> 
>   src/declarativeimports/plasmacomponents/qml/TextArea.qml 3f68934 
>   src/declarativeimports/plasmacomponents/qml/styles/ScrollViewStyle.qml PRE-CREATION 
>   src/declarativeimports/plasmacomponents/qml/styles/TextAreaStyle.qml PRE-CREATION 
>   src/declarativeimports/plasmaextracomponents/qml/ScrollArea.qml 3818142 
>   src/declarativeimports/plasmaextracomponents/qml/styles/ScrollViewStyle.qml cb0b190 
> 
> Diff: https://git.reviewboard.kde.org/r/119781/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140817/3e6674f4/attachment.html>