Review Request 119809: KIO: New job RestoreJob, public API KIO::restoreFromTrash().
Mark Gaiser
markg85 at gmail.com
Sun Aug 17 00:07:09 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119809/#review64658
-----------------------------------------------------------
src/core/restorejob.h
<https://git.reviewboard.kde.org/r/119809/#comment45224>
Copy paste error?
You miss:
@param urls ... (seems to be the current @param)
@param flags ...
@return ...
- Mark Gaiser
On aug 16, 2014, 10:40 p.m., David Faure wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119809/
> -----------------------------------------------------------
>
> (Updated aug 16, 2014, 10:40 p.m.)
>
>
> Review request for KDE Frameworks and Eike Hein.
>
>
> Repository: kio
>
>
> Description
> -------
>
> This was within libkonq as KonqMultiRestoreJob, public API KonqOperations::restoreTrashedItems().
>
>
> Diffs
> -----
>
> src/core/restorejob.cpp PRE-CREATION
> src/core/CMakeLists.txt 1e9ab98d2c0c27a696baab0bb8375c8cf81a3632
> src/core/restorejob.h PRE-CREATION
> autotests/fileundomanagertest.h 112657a1fcfea1e588e5fa53a1bbfccfe7a5de3d
> autotests/fileundomanagertest.cpp c1f253b4e41bff6d96baa9017fe8d6c70386efb8
>
> Diff: https://git.reviewboard.kde.org/r/119809/diff/
>
>
> Testing
> -------
>
> Added unittest; passes.
>
> It reminded me that this operation wasn't undoable yet, though.
>
>
> Thanks,
>
> David Faure
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140817/2788c78d/attachment.html>
More information about the Kde-frameworks-devel
mailing list