Review Request 119798: Generating PkgConig files from ECM

[Alex Merry]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119798/#review64585
-----------------------------------------------------------


I'm in favour of this - I was planning to do it myself before 1.0, but decided it wasn't important enough to rush.

Needs a unit test, please!


modules/ECMGeneratePkgConfigFile.cmake
<https://git.reviewboard.kde.org/r/119798/#comment45132>

    Spelling (Pkf->Pkg)



modules/ECMGeneratePkgConfigFile.cmake
<https://git.reviewboard.kde.org/r/119798/#comment45131>

    More for autotools, surely? We have .pri files for qmake.



modules/ECMGeneratePkgConfigFile.cmake
<https://git.reviewboard.kde.org/r/119798/#comment45133>

    Please document the arguments.



modules/ECMGeneratePkgConfigFile.cmake
<https://git.reviewboard.kde.org/r/119798/#comment45136>

    Why not have both be KF5Archive as the standard? And have LIB_NAME default to BASE_NAME (or vice versa)?
    
    After all, "KF5Archive" is what you would search for in CMake.



modules/ECMGeneratePkgConfigFile.cmake
<https://git.reviewboard.kde.org/r/119798/#comment45135>

    Not you?



modules/ECMGeneratePkgConfigFile.cmake
<https://git.reviewboard.kde.org/r/119798/#comment45134>

    This belongs in KDEInstallDirs.cmake, not here (as CMAKE_INSTALL_PKGCONFIGDIR, ideally). Projects that don't use KDEInstallDirs can create their own variable.
    
    Also, pkconfig -> pkgconfig.


- Alex Merry


On Aug. 14, 2014, 11:10 p.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119798/
> -----------------------------------------------------------
> 
> (Updated Aug. 14, 2014, 11:10 p.m.)
> 
> 
> Review request for Build System, KDE Frameworks and Harald Sitter.
> 
> 
> Repository: extra-cmake-modules
> 
> 
> Description
> -------
> 
> So we decided we wanted those .pc files, so I created a small script that generates one, I haven't used pc in the past, so feedback is welcome.
> 
> 
> Diffs
> -----
> 
>   modules/ECMGeneratePkgConfigFile.cmake PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/119798/diff/
> 
> 
> Testing
> -------
> 
> I added it in KCoreAddons, this is the patch:
> diff --git src/lib/CMakeLists.txt src/lib/CMakeLists.txt
> index 26eb5a1..3a07d1c 100644
> --- src/lib/CMakeLists.txt
> +++ src/lib/CMakeLists.txt
> @@ -188,4 +188,6 @@ install(FILES
>  
>  include(ECMGeneratePriFile)
>  ecm_generate_pri_file(BASE_NAME KCoreAddons LIB_NAME KF5CoreAddons DEPS "core" FILENAME_VAR PRI_FILENAME INCLUDE_INSTALL_DIR ${KF5_INCLUDE_INSTALL_DIR}/KCoreAddons)
> +ecm_generate_pkgconfig_file(BASE_NAME KCoreAddons LIB_NAME KF5CoreAddons DEPS Qt5Core FILENAME_VAR PC_FILENAME INCLUDE_INSTALL_DIR ${KF5_INCLUDE_INSTALL_DIR}/KCoreAddons)
> +install(FILES ${PC_FILENAME} DESTINATION ${ECM_PKGCONFIG_INSTALL_DIR})
>  install(FILES ${PRI_FILENAME} DESTINATION ${ECM_MKSPECS_INSTALL_DIR})
> 
> This is the result, on my system:
> 
> Name: KF5CoreAddons
> Version: 5.1.0
> Libs: -L/home/kde-devel/kde5/lib64 -l/home/kde-devel/kde5/lib64
> Cflags: -I/home/kde-devel/kde5/include/KF5/KCoreAddons 
> Requires: Qt5Core
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140815/5cf32012/attachment-0001.html>