Review Request 119781: Port TextArea to QtControls

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119781/#review64522
-----------------------------------------------------------



src/declarativeimports/plasmacomponents/qml/TextArea.qml
<https://git.reviewboard.kde.org/r/119781/#comment45067>

    @inherit QtQuick.Controls.TextArea
    
    it needs to be the original module name, not the alias we give it.



src/declarativeimports/plasmacomponents/qml/TextArea.qml
<https://git.reviewboard.kde.org/r/119781/#comment45068>

    would this be useful upstream?



src/declarativeimports/plasmacomponents/qml/styles/TextAreaStyle.qml
<https://git.reviewboard.kde.org/r/119781/#comment45071>

    can you add a comment that this is a local ScrollViewStyle and not QtQuick.Controls.Styles.ScrollViewStyle
    
    I got easily confused.



src/declarativeimports/plasmacomponents/qml/styles/TextAreaStyle.qml
<https://git.reviewboard.kde.org/r/119781/#comment45070>

    I would lose the "property <type>" prefix
    
    it makes it clear you're just adjusting a property in a parent class, not creating anything new.



src/declarativeimports/plasmacomponents/qml/styles/TextAreaStyle.qml
<https://git.reviewboard.kde.org/r/119781/#comment45072>

    do we need to set the padding from the frame margins, I can't see that anywhere



src/declarativeimports/plasmacomponents/qml/styles/TextAreaStyle.qml
<https://git.reviewboard.kde.org/r/119781/#comment45073>

    What's this for?



src/declarativeimports/plasmaextracomponents/qml/ScrollArea.qml
<https://git.reviewboard.kde.org/r/119781/#comment45069>

    did you move the other styles too, or are there now 2 style folders?


- David Edmundson


On Aug. 14, 2014, 10:02 a.m., Marco Martin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119781/
> -----------------------------------------------------------
> 
> (Updated Aug. 14, 2014, 10:02 a.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> This ports TextArea to Qtcontrols, all old properties/functions work (except for errorHighlight that was a stub already)
> moves also the scrollview style to make everything in the same place. (needs to be more complete still before becoming a proper import)
> 
> 
> Diffs
> -----
> 
>   src/declarativeimports/plasmacomponents/qml/TextArea.qml 3f68934 
>   src/declarativeimports/plasmacomponents/qml/styles/ScrollViewStyle.qml PRE-CREATION 
>   src/declarativeimports/plasmacomponents/qml/styles/TextAreaStyle.qml PRE-CREATION 
>   src/declarativeimports/plasmaextracomponents/qml/ScrollArea.qml 3818142 
>   src/declarativeimports/plasmaextracomponents/qml/styles/ScrollViewStyle.qml cb0b190 
> 
> Diff: https://git.reviewboard.kde.org/r/119781/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140814/8cb7dd0d/attachment-0001.html>