Review Request 119755: Support more number types in haskell highlighting

Dominik Haumann dhaumann at kde.org
Wed Aug 13 19:39:18 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119755/#review64499
-----------------------------------------------------------

Ship it!


Patch looks good, but please increase the version number in the language element.

- Dominik Haumann


On Aug. 13, 2014, 4:33 p.m., Bastian Holst wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119755/
> -----------------------------------------------------------
> 
> (Updated Aug. 13, 2014, 4:33 p.m.)
> 
> 
> Review request for Kate, KDE Frameworks and Christoph Cullmann.
> 
> 
> Repository: ktexteditor
> 
> 
> Description
> -------
> 
> Support highlighting for the following types of numbers:
> * octal numbers
> * hexadecimal numbers
> * floating point numbers with exponent notation
> 
> 
> Diffs
> -----
> 
>   src/syntax/data/haskell.xml 49583a116df9b3f3d86e65a617729385048455b7 
> 
> Diff: https://git.reviewboard.kde.org/r/119755/diff/
> 
> 
> Testing
> -------
> 
> Manually testing with a number of Haskell files
> 
> 
> Thanks,
> 
> Bastian Holst
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140813/be96ee0d/attachment.html>


More information about the Kde-frameworks-devel mailing list