Review Request 119530: kcoreaddons: Fix kautosave doesn't work with more than 1 file per application

Andreas Xavier andxav at
Mon Aug 11 21:22:03 UTC 2014

This is an automatically generated e-mail. To reply, visit:

(Updated Aug. 11, 2014, 9:22 p.m.)

Review request for KDE Frameworks and David Faure.

Repository: kcoreaddons


kautosave doesn't work when any app tries to use a second filename, because it doesn't filter on filename.  The unit tests can be droppped into master to show the problem, if you remove the include on line 21.

This patch:
1. Adds unit tests to test more behavior mentioned in the header.
2. Fixes kautosave working with multple files per application.
3. Fixes filenaming brittleness, which would cause kautosave to randomly fail when the last 3 randomly generated characters in the filename matched any 3 consequtive chracters in the managed filename.

Diffs (updated)

  src/lib/io/kautosavefile_p.cpp PRE-CREATION 
  src/lib/io/kautosavefile_p.h PRE-CREATION 
  src/lib/io/kautosavefile.cpp 13a13d7 
  src/lib/io/kautosavefile.h 05cc3ae 
  src/lib/CMakeLists.txt 26eb5a1 
  autotests/kautosavefiletest.h cf70f4c 
  autotests/kautosavefiletest.cpp ec0309e 



Ran unit tests.
Ran kdeedu with kanagram.


Andreas Xavier

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <>

More information about the Kde-frameworks-devel mailing list