Review Request 119699: KIO: add public API isClipboardDataCut/setClipboardDataCut.

Eike Hein hein at kde.org
Mon Aug 11 19:12:53 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119699/#review64315
-----------------------------------------------------------

Ship it!


Looks good to me!

- Eike Hein


On Aug. 10, 2014, 8:59 p.m., David Faure wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119699/
> -----------------------------------------------------------
> 
> (Updated Aug. 10, 2014, 8:59 p.m.)
> 
> 
> Review request for KDE Frameworks and Eike Hein.
> 
> 
> Repository: kio
> 
> 
> Description
> -------
> 
> This replaces the various copies of the code dealing with that in KIO,
> and will replace the original code in libkonq's KonqMimeData (which will
> then be removed).
> 
> Unittest moved from libkonq and ported to non-deprecated KF5 API.
> 
> 
> Diffs
> -----
> 
>   autotests/CMakeLists.txt 4d845cc924883c9b56f188e926918110987175b7 
>   autotests/fileundomanagertest.cpp 12d9013160dbd4432bca512b329a3b3566e33a61 
>   autotests/pastetest.h PRE-CREATION 
>   autotests/pastetest.cpp PRE-CREATION 
>   src/filewidgets/kfilepreviewgenerator.cpp b14b1d5f3aaa3b8a31bb3936ab6c4a77ae49b5ba 
>   src/widgets/paste.h 085d047a3d225f4c70a1a05568b00ae24649a144 
>   src/widgets/paste.cpp b2a84b0dd7ee000cbdfbfba289f7afbcc9c41d17 
> 
> Diff: https://git.reviewboard.kde.org/r/119699/diff/
> 
> 
> Testing
> -------
> 
> Compiles, fileundomanagertest still passes.
> 
> 
> Thanks,
> 
> David Faure
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140811/badfcc9c/attachment.html>


More information about the Kde-frameworks-devel mailing list