Review Request 119698: Save radio button index in QGroupBox that are composed only by radio buttons

Albert Astals Cid aacid at kde.org
Mon Aug 11 12:40:12 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119698/
-----------------------------------------------------------

(Updated ago. 11, 2014, 12:40 p.m.)


Review request for KDE Frameworks.


Repository: kconfigwidgets


Description
-------

We are suggesting people to port from deprecated KButtonGroup to QGroupBox but the dialog manager does not behave the same. This patch fixes it by assuming that in a groupbox that is composed exclusively by radio buttons and whose config item is an int to save the index of the checked radio button instead of if the group box itself is checked.


Diffs (updated)
-----

  src/kconfigdialogmanager.cpp 94d3cd1 

Diff: https://git.reviewboard.kde.org/r/119698/diff/


Testing
-------

KGeography frameworks with KButtonGroup ported to QGroupBox works.


Thanks,

Albert Astals Cid

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140811/45095037/attachment.html>


More information about the Kde-frameworks-devel mailing list