Review Request 119698: Save radio button index in QGroupBox that are composed only by radio buttons

[Aleix Pol Gonzalez]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119698/#review64202
-----------------------------------------------------------



src/kconfigdialogmanager.cpp
<https://git.reviewboard.kde.org/r/119698/#comment44860>

    It could be a QSet<QGroupBox*>, you're already doing the cast and checking it's not null anyway.



src/kconfigdialogmanager.cpp
<https://git.reviewboard.kde.org/r/119698/#comment44855>

    You probably want to remove the widget if the widget is deleted, even though you're not accessing through them.


And maybe you can use the more generic type QAbstractButton, only maybe, I'm unsure, up to you.

- Aleix Pol Gonzalez


On Aug. 10, 2014, 8:28 p.m., Albert Astals Cid wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119698/
> -----------------------------------------------------------
> 
> (Updated Aug. 10, 2014, 8:28 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kconfigwidgets
> 
> 
> Description
> -------
> 
> We are suggesting people to port from deprecated KButtonGroup to QGroupBox but the dialog manager does not behave the same. This patch fixes it by assuming that in a groupbox that is composed exclusively by radio buttons and whose config item is an int to save the index of the checked radio button instead of if the group box itself is checked.
> 
> 
> Diffs
> -----
> 
>   src/kconfigdialogmanager.cpp 94d3cd1 
> 
> Diff: https://git.reviewboard.kde.org/r/119698/diff/
> 
> 
> Testing
> -------
> 
> KGeography frameworks with KButtonGroup ported to QGroupBox works.
> 
> 
> Thanks,
> 
> Albert Astals Cid
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140810/fdae5de5/attachment-0001.html>