Review Request 119505: Instance our onw QFileDialog instead of using getExistingDirectoryUrl

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119505/#review64101
-----------------------------------------------------------


Well, I fixed this for Qt 5.4.

https://codereview.qt-project.org/89486
https://codereview.qt-project.org/89487
(both merged in, the last one 2 days ago)

so this workaround should be within Qt version ifdefs (< 5.4.0), and the commit log doesn't need to describe the Qt bug, it's fully analyzed and fixed already.

- David Faure


On Aug. 5, 2014, 10:01 p.m., Àlex Fiestas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119505/
> -----------------------------------------------------------
> 
> (Updated Aug. 5, 2014, 10:01 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kio
> 
> 
> Description
> -------
> 
> getExistingDirectoryUrl only works for local files so we have to implement it on our own for now.
> 
> As for Qt, QFileDialog::getExistingDirectoryUrl calls QUrl.toLocalFile, if we remove that, further down the code path _qt_get_directory is called which checks that the file exists but since Qt is not able to talk all our kios (for example smb) it will return false.
> So at the moment we are forced to implement it ourselves.
> 
> 
> Diffs
> -----
> 
>   src/widgets/kurlrequester.cpp cf0b0c7 
> 
> Diff: https://git.reviewboard.kde.org/r/119505/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Àlex Fiestas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140809/22dc6400/attachment.html>