Review Request 119534: take defaults from a plasma look and feel package, if available

Marco Martin notmart at gmail.com
Thu Aug 7 15:19:46 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119534/
-----------------------------------------------------------

(Updated Aug. 7, 2014, 3:19 p.m.)


Review request for KDE Frameworks and Plasma.


Changes
-------

tries a slightly different approach for the colors: if the l&f package provides a file called colors, use that, otherwise read a colorscheme name from the defaults file. Opinions on what is the best way welcome


Repository: frameworkintegration


Description
-------

there will be support for some kind of "mega theme" that besides providing files for splashscreen, lockscreen etc, will define what defaults to use among icons, colors, fonts etc.

This is a first start of it for reading the defaults. The theme file is stored in a plasma package, but the patch resolves the correct path by hand, not requiring linking to libplasma.
right now only a couple of settings is used, mostly to see if the direction is good.


Diffs (updated)
-----

  CMakeLists.txt ef96e16 
  src/platformtheme/kdeplatformfiledialoghelper.h e2419e1 
  src/platformtheme/kdeplatformfiledialoghelper.cpp 799312e 
  src/platformtheme/khintssettings.h 57f1864 
  src/platformtheme/khintssettings.cpp f9e068d 

Diff: https://git.reviewboard.kde.org/r/119534/diff/


Testing
-------


Thanks,

Marco Martin

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140807/b43b5ff4/attachment.html>


More information about the Kde-frameworks-devel mailing list