Review Request 118263: Port polkit-kde-agent to KF5::KDELibs4Support and KF5::IconThemes

[Martin Bříza]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118263/
-----------------------------------------------------------

(Updated Aug. 7, 2014, 9:54 a.m.)


Status
------

This change has been discarded.


Review request for KDE Frameworks and Polkit KDE Agent.


Repository: polkit-kde-agent-1


Description
-------

Use -DUSE_QT4=true to build against kdelibs4; -DUSE_QT5=true to build against KF5. Don't use anything to let cmake decide, with KF5 being a priority. 

Sorry for using KDELibs4Support - I tried to not do it but it required 8 frameworks and a massive rewrite.


Diffs
-----

  AuthDialog.h 620145d 
  AuthDialog.cpp f2c4886 
  CMakeLists.txt f79b88f 
  main.cpp 33ef236 
  policykitlistener.cpp 6da9461 
  polkit-kde-authentication-agent-1.desktop.in aa088cc 

Diff: https://git.reviewboard.kde.org/r/118263/diff/


Testing
-------


Thanks,

Martin Bříza

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140807/6b630e5c/attachment.html>