Review Request 119534: take defaults from a plasma look and feel package, if available

[Marco Martin]

> On Aug. 4, 2014, 2:22 p.m., David Edmundson wrote:
> > src/platformtheme/khintssettings.cpp, line 53
> > <https://git.reviewboard.kde.org/r/119534/diff/3/?file=294399#file294399line53>
> >
> >     I don't think we want to call the default look and feel package something like
> >     maybe org.kde.defaultlookandfeel
> >     
> >     otherwise you're just putting the type in the name which is just confusing.
> 
> Marco Martin wrote:
>     ok, going to modify the name of the one provided in plasma-workspace then.
> 
> David Edmundson wrote:
>     Oh that might get quite invasive. I won't insist on doing that then.
>     
>     I guess other people would call it org.caledonia.lookandfeel, it's not like KDE would ever ship two (is it?)
> 
> Marco Martin wrote:
>     as kde, probably going to be an org.kde.oxygen one, to have a quick kde4ish look
> 
> David Edmundson wrote:
>     so should this be org.kde.breeze.lookandfeel & org.kde.oxygen.lookandfeel respectively

bah, not necessarly, even just org.kde.breeze (or org.kde.loonandfeel for the default is fine as well)
since they are installed under their own prefix (plasma/look-and-feel) they don't risk to clash with other types of packages anyways so lookandfeel in the name itself is not needed


- Marco


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119534/#review63781
-----------------------------------------------------------


On Aug. 4, 2014, 3:18 p.m., Marco Martin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119534/
> -----------------------------------------------------------
> 
> (Updated Aug. 4, 2014, 3:18 p.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: frameworkintegration
> 
> 
> Description
> -------
> 
> there will be support for some kind of "mega theme" that besides providing files for splashscreen, lockscreen etc, will define what defaults to use among icons, colors, fonts etc.
> 
> This is a first start of it for reading the defaults. The theme file is stored in a plasma package, but the patch resolves the correct path by hand, not requiring linking to libplasma.
> right now only a couple of settings is used, mostly to see if the direction is good.
> 
> 
> Diffs
> -----
> 
>   src/platformtheme/khintssettings.h 57f1864 
>   src/platformtheme/khintssettings.cpp f9e068d 
> 
> Diff: https://git.reviewboard.kde.org/r/119534/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140804/8e2993e2/attachment-0001.html>