Review Request 119594: fix FileDialog size restorage

Thomas Lübking thomas.luebking at
Mon Aug 4 11:57:25 UTC 2014

This is an automatically generated e-mail. To reply, visit:

(Updated Aug. 4, 2014, 11:57 vorm.)

Review request for KDE Frameworks, kdelibs, Aleix Pol Gonzalez, Lukáš Tinkl, and Martin Klapetek.


Misunderstanding - I tested the dir dialog explicitly ;-)

Summary (updated)

fix FileDialog size restorage

Repository: frameworkintegration

Description (updated)

- saving in the deconstrutor is insufficient,
  the dialog might survive the runtime
  -> needs to be saved when the dialog is finished or just closed
  (the closeEvent is not invoked if at least a sync dialog is finished)

- ensure a windowHandle and then restore the window size before calling ::exec()
- workaround an apparent QWidget QPA bug where even for a created platform window
  the QWindow geometry is not applied on the QWidget

Diffs (updated)

  src/platformtheme/kdeplatformfiledialogbase.cpp b823bc7 
  src/platformtheme/kdeplatformfiledialogbase_p.h 8ef5b1e 
  src/platformtheme/kdeplatformfiledialoghelper.h 406a4f1 
  src/platformtheme/kdeplatformfiledialoghelper.cpp 520b6f5 





Thomas Lübking

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <>

More information about the Kde-frameworks-devel mailing list