Review Request 119337: Wait for KMainWindow size restoring before auto saving the size

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119337/#review63736
-----------------------------------------------------------


This patch sounds wrong (at first sight) because, well, this code worked in Qt4/kdelibs4, so if such a patch is necessary, then the difference compared to the Qt4/kdelibs4 behavior needs to be investigated in order to fully explain the patch. The last comment about a possible change of behavior coming from the XCB QPA goes in the right direction :-)

- David Faure


On July 17, 2014, 1:21 p.m., Martin Klapetek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119337/
> -----------------------------------------------------------
> 
> (Updated July 17, 2014, 1:21 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kxmlgui
> 
> 
> Description
> -------
> 
> Playing a bit with the KXmlGuiWindow test showed that it didn't restore its size properly on reopening. I found out that KWindowConfig::saveWindowSize() is called before KWindowConfig::restoreWindowSize() which results in overwriting the values in the config file and KWindowConfig::restoreWindowSize() then reads the changed values.
> 
> So this patch calls KWindowConfig::saveWindowSize() only after we have applied the size from the config file. Additionally, it checks if the windowHandle() we're trying to resize is NULL as that can result in no resize and yet the d->sizeApplied being wrongly set to true.
> 
> 
> Diffs
> -----
> 
>   src/kmainwindow.cpp e273a76 
> 
> Diff: https://git.reviewboard.kde.org/r/119337/diff/
> 
> 
> Testing
> -------
> 
> KXmlGuiWindow (the one in tests/) now correctly stores & restores its size.
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140804/ae6442e6/attachment.html>