Review Request 119512: Fix saving/loading of file dialog sizes
Thomas Lübking
thomas.luebking at gmail.com
Sun Aug 3 19:19:40 UTC 2014
On Juli 28, 2014, 10:17 vorm., Lukáš Tinkl wrote:
> > If the only issue is the open ::exec() TODO, you might "trick" it by calling ::winId(), then restore the size and ultimately ::exec()
> >
> > Otherwise you could open an own nested eventloop instead of relying on the dialogs exec, but that'd be less elegant.
> >
> > In either case I don't see why bringing your own config re/storage.
>
> Lukáš Tinkl wrote:
> The trick with winId() unfortunately doesn't work, the dialog gets restored to the default size, not the saved one... :/ Any other ideas?
>
> Thomas Lübking wrote:
> I'm not gonna say "impossible", but the reason could then not be the absence of a windowHandle()
> Eventually sth. alters the window size post the restore.
>
> Have you checked for presence of a m_dialog->windowHandle() after calling m_dialog->winId() and m_dialog->size() after calling
> KWindowConfig::restoreWindowSize(m_dialog->windowHandle(), conf->group("FileDialogSize")); and before calling m_dialog->exec() ?
>
> Martin Klapetek wrote:
> KWindowConfig::restoreWindowSize is broken for some reason.
>
> I did some investigation and basically what happens is this:
> - KWindowConfig::restoreWindowSize resutls in QXcbWindow::setGeometry call
> - geometry is set to the QWindow, but no to its QWidgets (no idea why)
> - when event loop hits next loop, widgets are checked if their size >= their min size
> - because they didn't receive the updated geometry, this^ is not true
> - the widgets get resized to their min size
> - the window has a wrong geometry
>
> I don't know why the widgets don't receive the event however, my knowledge in this is lacking.
>
> Lukáš Tinkl wrote:
> So how do we proceed with this one? Having tiny filedialogs is annoying as hell...
>
> Thomas Lübking wrote:
> Fix KWindowConfig::restoreWindowSize, I'd say.
> I assume calling
>
> + window->create();
>
> before "window->resize(width, height);" in frameworks/kconfig/src/gui/kwindowconfig.cpp:81 should be be sufficient?
> (This should ensure d->platformWindow->setGeometry(QRect(position(), newSize)); is called in QWindow::resize())
>
> Lukáš Tinkl wrote:
> Nope, it didn't work unfortunately :/
>
> Thomas Lübking wrote:
> You must still ensure that there's a QWindow before the Dialog::exec() call, ie. calling ::winId() is still required in addition on this particular case.
>
> Lukáš Tinkl wrote:
> Done that, didn't help
>
> Thomas Lübking wrote:
> What's your testcase on this?
>
> QFileDialog *dlg = new QFileDialog;
> dlg->setFileMode(QFileDialog::Directory);
> dlg->setOption(QFileDialog::ShowDirsOnly);
> dlg->exec();
>
> gets me a ::windowHandle() before, but *does* get me one after.
>
> If I then call
> KSharedConfig::Ptr conf = KSharedConfig::openConfig();
> KWindowConfig::restoreWindowSize(m_dialog->windowHandle(), conf->group("FileDialogSize"));
>
> and from there
> window->create();
> right after the
>
> if (!window) {
> return;
> }
>
> check, I'm "sorry" to say, but the dialog size now _is_ restored for me.
>
>
> --------------
> What rather seems a problem is that the size does not get stored when eg. closing the dialog via the titlebar "close" button.
> I've to say cancel or ok.
>
> Lukáš Tinkl wrote:
> Yup, it works with a plain Q(File)Dialog, what doesn't work here is the wrapper due to the abstraction layer in QPA imo
>
> Thomas Lübking wrote:
> Humm? QFileDialog of course invokes the platformtheme if XDG_CURRENT_DESKTOP is set to KDE.
>
> 1. I could trace the invocation (strace/qDebug())
> 2. I get a "better" filedialog as compared to an unset (or different, the Gtk+ thing sucks ;-) environment
>
> With mentioned changes it /does/ work here using /usr/lib/qt/plugins/platformthemes/KDEPlatformTheme.so, ie. this wrapper.
>
> I'll add two RRs for it.
>
> Lukáš Tinkl wrote:
> Great, thanks
>
> Thomas Lübking wrote:
> In case you wonder: I could not create a new request in the past 5h, RB does not respond on the link.
> I'll link them here as soon as RB woke up.
>
> Ben Cooksley wrote:
> Please report any faults in KDE infrastructure to Sysadmin through our usual channels - I have restarted Reviewboard, which will hopefully resolve the issue.
https://git.reviewboard.kde.org/r/119593/
https://git.reviewboard.kde.org/r/119594/
@Ben
I usually apply a "if it doesn't magically fix within the next 24h, i'll nag somebody" rule - esp. on weekends ;-)
Actually it seems Revireboard does respond, it's just *incredibly* slow (and at some point the browser will timeout)
This seems to be part of the new GUI?
- Thomas
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119512/#review63311
-----------------------------------------------------------
On Juli 28, 2014, 10:21 vorm., Lukáš Tinkl wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119512/
> -----------------------------------------------------------
>
> (Updated Juli 28, 2014, 10:21 vorm.)
>
>
> Review request for KDE Frameworks, kdelibs, Aleix Pol Gonzalez, and Martin Klapetek.
>
>
> Repository: frameworkintegration
>
>
> Description
> -------
>
> This patch tries to fix saving/restoring file dialog sizes. Using KWindowConfig::restoreWindowSize() doesn't work here with the modal exec() methods. Instead, the patch uses the same method as KDirSelectDialog.
>
>
> Diffs
> -----
>
> src/platformtheme/kdeplatformfiledialoghelper.h 406a4f1
> src/platformtheme/kdeplatformfiledialoghelper.cpp 520b6f5
> src/platformtheme/kdirselectdialog.cpp 9a4082a
> src/platformtheme/kdirselectdialog_p.h 5a8e758
>
> Diff: https://git.reviewboard.kde.org/r/119512/diff/
>
>
> Testing
> -------
>
> Current Plasma 5, working fine :)
>
>
> Thanks,
>
> Lukáš Tinkl
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140803/cd65b485/attachment-0001.html>
More information about the Kde-frameworks-devel
mailing list