Review Request 119577: Allow translations to have context again.

[Matthew Dawson]

> On Aug. 2, 2014, 1:37 p.m., Lukáš Tinkl wrote:
> > Translations might be broken due to https://bugreports.qt-project.org/browse/QTBUG-40444 , otherwise thanks for the fix!

Ok, I'll leave this to be picked up in 5.2 then, to avoid breaking the translations this cycle.  That should avoid the most breakage.  I'll commit after August 7th, so as not to change the translations already done for 5.1.


- Matthew


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119577/#review63677
-----------------------------------------------------------


On Aug. 2, 2014, 1:07 p.m., Matthew Dawson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119577/
> -----------------------------------------------------------
> 
> (Updated Aug. 2, 2014, 1:07 p.m.)
> 
> 
> Review request for KDE Frameworks and Matthew Dawson.
> 
> 
> Bugs: 337979
>     https://bugs.kde.org/show_bug.cgi?id=337979
> 
> 
> Repository: kconfig
> 
> 
> Description
> -------
> 
> Allow translations to have context again.
> 
> Switch to using QT_TRANSLATE_NOOP3 so that context information can be
> given for actions, allowing the translators to do better translations.
> 
> BUG: 337979
> FIXED-IN: 5.1.0
> 
> I don't know if it is worthwhile to get this in for 5.1.0, or wait for 5.2.  Would it help the translators to get it in now?  If not, I'll get it in for 5.2 (and update the FIXED-IN tag).
> 
> Also, is there an easy way to test translations?  It compiles, and the test suite does run, but I don't have any translations so I don't know if it actually works.  Any pointers to documentation would be great.
> 
> 
> Diffs
> -----
> 
>   src/gui/kstandardshortcut.cpp eb50888a263e9662bdac6c3e046d653577c003e4 
> 
> Diff: https://git.reviewboard.kde.org/r/119577/diff/
> 
> 
> Testing
> -------
> 
> Compiles, test suite passes.
> 
> 
> Thanks,
> 
> Matthew Dawson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140802/114500c8/attachment.html>