Review Request 119567: Also find catalog files that are symlinks

[Luigi Toscano]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119567/#review63656
-----------------------------------------------------------



src/docbookl10nhelper.cpp
<https://git.reviewboard.kde.org/r/119567/#comment44349>

    I'm pretty sure this is not needed: the script is called only during build time between the build directory and the source directory; unless the symlinks are created somehow before that phase.



src/xslt.cpp
<https://git.reviewboard.kde.org/r/119567/#comment44350>

    Uhm, but that's strange. Just to be sure, do I understand it correctly that every file in customization is sym-linked? O.o


- Luigi Toscano


On Ago. 1, 2014, 7:58 p.m., Harald Fernengel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119567/
> -----------------------------------------------------------
> 
> (Updated Ago. 1, 2014, 7:58 p.m.)
> 
> 
> Review request for Documentation, KDE Frameworks and Luigi Toscano.
> 
> 
> Repository: kdoctools
> 
> 
> Description
> -------
> 
> When building KF5 on Mac OS X with homebrew, the catalog and
> other files are symlinked from the 'Cellar' (install dir) to the
> homebrew prefix. After that, meinproc5 wouldn't find its catalog
> because it decides to ignore symbolic links. Removing that option
> fixes the build on Mac OS X.
> 
> 
> Diffs
> -----
> 
>   src/docbookl10nhelper.cpp 6eecb376cab6e3ba03e9548b3402eaa5e5530198 
>   src/xslt.cpp 3c81a172b00458419fc2f310cbdf76eb357336fc 
> 
> Diff: https://git.reviewboard.kde.org/r/119567/diff/
> 
> 
> Testing
> -------
> 
> Builds on Mac OS X
> 
> 
> Thanks,
> 
> Harald Fernengel
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140801/f26cde6e/attachment-0001.html>