Review Request 119540: don't construct bogus KAuthAction objects

[Harald Sitter]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119540/
-----------------------------------------------------------

(Updated Aug. 1, 2014, 2:35 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Frameworks, Hrvoje Senjan and Martin Bříza.


Repository: kconfigwidgets


Description
-------

KAuthAction(0) actually calls the QString constructor which will dispatch
bogus polkit auth checks, polkitqt and polkitd are not terribly happy about
those and subsequently don't want to talk to the KCM anymore, even if it
manages to create a proper Action

creating a null Action rather than accidentally triggering the QString
ctor ensures that we only do polkit interaction with reasonable actionids
making sure that authentication works as expected


Diffs
-----

  src/kcmodule.cpp 92e5427c121491e4ebf289addda040cc117cdd68 

Diff: https://git.reviewboard.kde.org/r/119540/diff/


Testing
-------

tested with clock kcm, succesfully can talk with the helper app if the bogus actionid "" wasn't used intermediately


Thanks,

Harald Sitter

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140801/f98c2c52/attachment.html>