Review Request 119563: Ship plasma_workspace.notifyrc with frameworkintegration

[Aleix Pol Gonzalez]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119563/#review63634
-----------------------------------------------------------


Well, you only get the frameworks integration when you're running Plasma 5...

Actually, frameworksintegration should move to kde/workspace at least. It's not a framework.

- Aleix Pol Gonzalez


On Aug. 1, 2014, 2:29 p.m., Martin Klapetek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119563/
> -----------------------------------------------------------
> 
> (Updated Aug. 1, 2014, 2:29 p.m.)
> 
> 
> Review request for KDE Frameworks and Harald Sitter.
> 
> 
> Repository: frameworkintegration
> 
> 
> Description
> -------
> 
> Add plasma_workspace.notifyrc to be installed with frameworkintegration. This file contains basic notification events and has preconfigured sounds for those, with this for example KMessageBox plays a sound etc. It's what used to be kde.notifyrc in KDE4 world.
> 
> I put it in frameworkintegration as it seems to be the best place for it, the default sounds etc. are a workspace integration after all, but plasma-workspace is too high in the stack.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt af3cce8 
>   plasma_workspace.notifyrc PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/119563/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140801/7e31c362/attachment-0001.html>