Review Request 119560: Avoid disappearing scrollbars

David Edmundson david at davidedmundson.co.uk
Fri Aug 1 13:16:03 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119560/#review63624
-----------------------------------------------------------

Ship it!


probably needs the BUG n comments that the other two places have. Either that or wrap all the other code in an else {} rather than using a return.

- David Edmundson


On Aug. 1, 2014, 11:56 a.m., Marco Martin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119560/
> -----------------------------------------------------------
> 
> (Updated Aug. 1, 2014, 11:56 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kitemviews
> 
> 
> Description
> -------
> 
> updateGeometries() temporarly changes the value of the scrollbar policy.
> make sure to have set it back when the function returns.
> It avoids scrollbars always disabled, see
> https://git.reviewboard.kde.org/r/119557/
> 
> 
> Diffs
> -----
> 
>   src/kcategorizedview.cpp 2d9296b 
> 
> Diff: https://git.reviewboard.kde.org/r/119560/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140801/4b7bef9a/attachment.html>


More information about the Kde-frameworks-devel mailing list