Review Request 119365: Fix the build of KHtml on Windows using MSVC 2013
Cristian Oneț
onet.cristian at gmail.com
Fri Aug 1 06:27:20 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119365/
-----------------------------------------------------------
(Updated Aug. 1, 2014, 6:27 a.m.)
Status
------
This change has been marked as submitted.
Review request for KDE Frameworks, kdewin and Martin Tobias Holmedahl Sandsmark.
Repository: khtml
Description
-------
This patch addresses these build issues:
1. Some Qt5::X11Extras were not properly guarded.
2. KDEWin is needed on Windows for 'unistd.h' and others.
3. 'fmod' migth be a macro which will screw up calls to std::fmod
Diffs
-----
CMakeLists.txt de34f3c8d7479811d536fbce2114f29a96693087
src/CMakeLists.txt bc7534667d6a39b334d038d55391e784c6527b1c
src/html/html_canvasimpl.cpp 18990eaa7ab00316471ecec0e9aa30b394aa4e02
tests/CMakeLists.txt d672fb56feb52da7308e844e0c86460e11778c07
Diff: https://git.reviewboard.kde.org/r/119365/diff/
Testing
-------
Build & run on Windows and Linux.
Thanks,
Cristian Oneț
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140801/87238170/attachment.html>
More information about the Kde-frameworks-devel
mailing list