Review Request 117150: use renamed kf5_entry.desktop file

[David Faure]

> On March 31, 2014, 2:39 p.m., Kevin Ottens wrote:
> > Ship It!
> 
> Kevin Ottens wrote:
>     Actually scrap that, seeing the confusion around those files I might have been mistaken myself.
> 
> Jonathan Riddell wrote:
>     This is looking for a language entry.desktop file as installed into /usr/share/locale/en_US/kf5_entry.desktop which has been renamed.
>     
>     It is not for a country entry.desktop file which gets installed into /usr/share/locale/l10n/gb/entry.desktop, these have not yet been renamed.
>

I would suggest to rename language files to something like kf5_language.desktop to clear up this confusion.


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117150/#review54682
-----------------------------------------------------------


On March 28, 2014, 7:24 p.m., Jonathan Riddell wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117150/
> -----------------------------------------------------------
> 
> (Updated March 28, 2014, 7:24 p.m.)
> 
> 
> Review request for KDE Frameworks and Aleix Pol Gonzalez.
> 
> 
> Repository: kxmlgui
> 
> 
> Description
> -------
> 
> entry.desktop got renamed, use the renamed file 
> https://git.reviewboard.kde.org/r/117087/
> 
> 
> Diffs
> -----
> 
>   src/khelpmenu.cpp 4f6ce7b 
> 
> Diff: https://git.reviewboard.kde.org/r/117150/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jonathan Riddell
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140430/019afaa8/attachment.html>