Review Request 117148: use renamed kf5_entry.desktop file

[David Faure]

> On April 29, 2014, 9:22 a.m., Jonathan Riddell wrote:
> > I disagree, ./src/kdecore/entry.desktop gets renamed to kf5_entry.desktop on install and installs into /usr/share/locale/en_US/kf5_entry.desktop so it is the locale entry.desktop file which has been renamed not the country entry.desktop files.  renaming them in the language packs is future work.
> >
> 
> Jonathan Riddell wrote:
>     seems country entry.desktop files have also been renamed by someone else, but that's a separate topic.
>
> 
> Aleix Pol Gonzalez wrote:
>     Yes, that was 689905382be5d2ed36a1cbc15810b323964fa328 in kdelibs4support. Adding them to see what should we do.
> 
> David Faure wrote:
>     OK. Then don't forget that "future work" .... (renaming the desktop files in l10n-kf5)

Actually, while we're at it, can't we remove future confusion by giving the language files a DIFFERENT filename than the country desktop files?
Change this to kf5_language.desktop or something like that?


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117148/#review56831
-----------------------------------------------------------


On April 29, 2014, 11:10 a.m., Jonathan Riddell wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117148/
> -----------------------------------------------------------
> 
> (Updated April 29, 2014, 11:10 a.m.)
> 
> 
> Review request for KDE Frameworks, Aleix Pol Gonzalez, Dan Vrátil, and Lukáš Tinkl.
> 
> 
> Repository: kconfigwidgets
> 
> 
> Description
> -------
> 
> entry.desktop got renamed, use the renamed file 
> https://git.reviewboard.kde.org/r/117087/
> 
> 
> Diffs
> -----
> 
>   src/klanguagebutton.cpp 9f0c055 
> 
> Diff: https://git.reviewboard.kde.org/r/117148/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jonathan Riddell
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140430/63b3c642/attachment.html>