Review Request 117895: rename kdebugdialog5 internally and move documentation for co-installability

[Aurélien Gâteau]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117895/#review56968
-----------------------------------------------------------


You need to change docs/CMakeLists.txt to use kdebugdialog5 instead of kdebudialog. It also seems to me that src/kdebugdialog/main.cpp needs to be changed to pass "kdebugdialog5" to K4AboutData, otherwise khelpcenter will try to load the old doc.

- Aurélien Gâteau


On April 30, 2014, 12:39 p.m., Jonathan Riddell wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117895/
> -----------------------------------------------------------
> 
> (Updated April 30, 2014, 12:39 p.m.)
> 
> 
> Review request for KDE Frameworks and Aurélien Gâteau.
> 
> 
> Repository: kdelibs4support
> 
> 
> Description
> -------
> 
> rename kdebugdialog5 internally and move documentation for co-installability.  the docs clash with equivalent from kdelibs4 land.
> 
> internal rename needed so when you click the Help button khelpcentre gets the right location
> 
> 
> Diffs
> -----
> 
>   docs/kdebugdialog/CMakeLists.txt 3d2c316 
>   docs/kdebugdialog/index.docbook dc7c4c4 
>   docs/kdebugdialog5/CMakeLists.txt PRE-CREATION 
>   docs/kdebugdialog5/index.docbook PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/117895/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jonathan Riddell
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140430/78c3efd2/attachment.html>