Review Request 117799: Clean up private slots in KCompletion

[Frank Reininghaus]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117799/#review56956
-----------------------------------------------------------

Ship it!


The change looks reasonable to me. It's a very straightforward transformation, and  I haven't spotted anything that looks like it could break things. Considering that the tests still work for you, I think that there is no reason not to push it.

- Frank Reininghaus


On April 26, 2014, 11:23 p.m., David Gil Oliva wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117799/
> -----------------------------------------------------------
> 
> (Updated April 26, 2014, 11:23 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kcompletion
> 
> 
> Description
> -------
> 
> Clean up private slots
>     
> Some private slots didn't have the _k_* form and some methods with the _k_* form weren't even used as slots.
> 
> 
> Diffs
> -----
> 
>   src/kcombobox.h 752db2c 
>   src/kcombobox.cpp da31394 
>   src/kcompletionbox.h 3295c24 
>   src/kcompletionbox.cpp 7d03d64 
>   src/khistorycombobox.h ea56358 
>   src/khistorycombobox.cpp 9e2f0be 
>   src/klineedit.h 705147d 
>   src/klineedit.cpp 9d02c12 
>   src/klineedit_p.h e544224 
> 
> Diff: https://git.reviewboard.kde.org/r/117799/diff/
> 
> 
> Testing
> -------
> 
> It builds. Autotests pass.
> 
> 
> Thanks,
> 
> David Gil Oliva
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140430/9e292010/attachment.html>