ki18n_wrap_ui and libraries

[Martin Graesslin]

On Tuesday 29 April 2014 21:27:29 Chusslove Illich wrote:
> > [: Martin Gräßlin :]
> > If my understanding is correct one needs to define TRANSLATION_DOMAIN
> > before including KLocalizedString for library code. But the CMake macro
> > ki18n_wrap_ui does not allow to define the TRANSLATION_DOMAIN.
> > 
> > Is there something I have overseen or is that indeed missing from the
> > macro?
> 
> It was my initial intention that ki18n_wrap_ui had translation domain
> argument, but after some discussion people thought it better to have
> add_definitions(-DTRANSLATION_DOMAIN=\"kfoobar\") cover uic-generated code
> too.

sounds reasonable. May I suggest to add this to the documentation? Sounds also 
like a better solution than to have the private header in general for the 
libraries.

Cheers
Martin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140429/08b0cdd1/attachment.sig>