Review Request 117804: Introduce ki18n_install and refresh ki18n_install_ts_files

[Chusslove Illich]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117804/#review56918
-----------------------------------------------------------

Ship it!


Looks good to me.

I was only wondering about the assumed directory structure in the tarball. It is indeed as in e.g. extragear releases, however the Gettext convention is top grouping by domain instead of by language. But I suppose we don't have to think about this right now, as if someone later wants the conventional Gettext structure, we can add an option parameter to the macro.


- Chusslove Illich


On April 27, 2014, 8:45 p.m., Aurélien Gâteau wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117804/
> -----------------------------------------------------------
> 
> (Updated April 27, 2014, 8:45 p.m.)
> 
> 
> Review request for KDE Frameworks and Chusslove Illich.
> 
> 
> Repository: ki18n
> 
> 
> Description
> -------
> 
> This patch adds a ki18n_install() function to KF5I18nMacros.cmake. This function makes it easy to install all the .po and .js files of a framework.
> 
> The primary user of this function is the build system of the framework tarballs. The tarballs will ship with a po/ directory which follows the structure expected by ki18n_install(). The only necessary change is to add the following lines to the root CMakeLists.txt file:
> 
>     if (IS_DIRECTORY "${CMAKE_CURRENT_SOURCE_DIR}/po")
>         ki18n_install(po)
>     endif()
> 
> Since the code checks for the presence of a po/ directory, it can be committed in the framework repository (no need for the tarball release scripts to alter the CMake files), making it easier for developers to reproduce the situation of a released tarball by creating/copying a po/ directory in their working copy.
> 
> I have a similar patch for kdoctools.
> 
> 
> Diffs
> -----
> 
>   cmake/KF5I18NMacros.cmake 2fe800b 
> 
> Diff: https://git.reviewboard.kde.org/r/117804/diff/
> 
> 
> Testing
> -------
> 
> Applied the changes locally to KIconThemes, tested with and without the po/ directory.
> 
> 
> Thanks,
> 
> Aurélien Gâteau
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140429/b16f3186/attachment.html>