Review Request 117148: use renamed kf5_entry.desktop file
Aleix Pol Gonzalez
aleixpol at kde.org
Tue Apr 29 11:09:49 UTC 2014
> On April 29, 2014, 9:22 a.m., Jonathan Riddell wrote:
> > I disagree, ./src/kdecore/entry.desktop gets renamed to kf5_entry.desktop on install and installs into /usr/share/locale/en_US/kf5_entry.desktop so it is the locale entry.desktop file which has been renamed not the country entry.desktop files. renaming them in the language packs is future work.
> >
>
> Jonathan Riddell wrote:
> seems country entry.desktop files have also been renamed by someone else, but that's a separate topic.
>
Yes, that was 689905382be5d2ed36a1cbc15810b323964fa328 in kdelibs4support. Adding them to see what should we do.
- Aleix
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117148/#review56831
-----------------------------------------------------------
On March 28, 2014, 7:22 p.m., Jonathan Riddell wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117148/
> -----------------------------------------------------------
>
> (Updated March 28, 2014, 7:22 p.m.)
>
>
> Review request for KDE Frameworks and Aleix Pol Gonzalez.
>
>
> Repository: kconfigwidgets
>
>
> Description
> -------
>
> entry.desktop got renamed, use the renamed file
> https://git.reviewboard.kde.org/r/117087/
>
>
> Diffs
> -----
>
> src/klanguagebutton.cpp 9f0c055
>
> Diff: https://git.reviewboard.kde.org/r/117148/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jonathan Riddell
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140429/07e6a704/attachment.html>
More information about the Kde-frameworks-devel
mailing list