Review Request 117795: Adapt to yaml file renaming ($framework.yaml => metainfo.yaml)

Alex Merry alex.merry at kde.org
Sun Apr 27 09:49:24 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117795/#review56669
-----------------------------------------------------------

Ship it!


Ship It!

- Alex Merry


On April 27, 2014, 9:40 a.m., Aurélien Gâteau wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117795/
> -----------------------------------------------------------
> 
> (Updated April 27, 2014, 9:40 a.m.)
> 
> 
> Review request for KDE Frameworks and Aurélien Gâteau.
> 
> 
> Repository: kapidox
> 
> 
> Description
> -------
> 
> The dependency diagram code used to extract the framework name from the name of the yaml file, but that is not possible anymore. We can't use the name of the directory containing the code because build.kde.org stores the framework code under different names. Therefore I decided to use the name of the project() from the toplevel CMakeLists.txt. I rewrote parse_fancyname() to get the info from the CMakeLists.txt instead of README.md for consistency.
> 
> That patch is unfortunately quite large as the changes cascaded quite a lot.
> 
> 
> Diffs
> -----
> 
>   src/kgenapidox 8fbffb1 
>   src/kapidox/data/dependencies.md.mustache 5d34042 
>   src/kapidox/__init__.py 61e6a13 
>   src/depdiagram-prepare 320502f 
>   src/kgenframeworksapidox 101f9b3 
> 
> Diff: https://git.reviewboard.kde.org/r/117795/diff/
> 
> 
> Testing
> -------
> 
> - Regenerated all the diagrams.
> - Ran kgenframeworksapidox on all the frameworks.
> - Ran kgenapidox on one framework.
> 
> 
> Thanks,
> 
> Aurélien Gâteau
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140427/a851b7e1/attachment.html>


More information about the Kde-frameworks-devel mailing list