Review Request 117795: Adapt to yaml file renaming ($framework.yaml => metainfo.yaml)

Alex Merry alex.merry at kde.org
Sat Apr 26 19:27:28 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117795/#review56646
-----------------------------------------------------------



src/depdiagram-prepare
<https://git.reviewboard.kde.org/r/117795/#comment39499>

    This will break when we start putting VERSION arguments into project() calls (after we depend on CMake 3.0).



src/kapidox/__init__.py
<https://git.reviewboard.kde.org/r/117795/#comment39502>

    As before, this will break with a VERSION argument (or, indeed, any languages).



src/kgenframeworksapidox
<https://git.reviewboard.kde.org/r/117795/#comment39500>

    Not needed any more



src/kgenframeworksapidox
<https://git.reviewboard.kde.org/r/117795/#comment39501>

    don't bother checking for README.md any more (this script doesn't care about it).


- Alex Merry


On April 26, 2014, 7:01 p.m., Aurélien Gâteau wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117795/
> -----------------------------------------------------------
> 
> (Updated April 26, 2014, 7:01 p.m.)
> 
> 
> Review request for KDE Frameworks and Alex Merry.
> 
> 
> Repository: kapidox
> 
> 
> Description
> -------
> 
> The dependency diagram code used to extract the framework name from the name of the yaml file, but that is not possible anymore. We can't use the name of the directory containing the code because build.kde.org stores the framework code under different names. Therefore I decided to use the name of the project() from the toplevel CMakeLists.txt. I rewrote parse_fancyname() to get the info from the CMakeLists.txt instead of README.md for consistency.
> 
> That patch is unfortunately quite large as the changes cascaded quite a lot.
> 
> 
> Diffs
> -----
> 
>   src/depdiagram-prepare 320502f 
>   src/kapidox/__init__.py 61e6a13 
>   src/kapidox/data/dependencies.md.mustache 5d34042 
>   src/kgenapidox 8fbffb1 
>   src/kgenframeworksapidox 101f9b3 
> 
> Diff: https://git.reviewboard.kde.org/r/117795/diff/
> 
> 
> Testing
> -------
> 
> - Regenerated all the diagrams.
> - Ran kgenframeworksapidox on all the frameworks.
> - Ran kgenapidox on one framework.
> 
> 
> Thanks,
> 
> Aurélien Gâteau
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140426/643a84e2/attachment.html>


More information about the Kde-frameworks-devel mailing list