Review Request 117688: Do not skip a language if there is no application catalog for it

Kevin Ottens ervin at kde.org
Sat Apr 26 15:30:31 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117688/#review56630
-----------------------------------------------------------

Ship it!


Ship It!

- Kevin Ottens


On April 22, 2014, 1:39 p.m., Aurélien Gâteau wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117688/
> -----------------------------------------------------------
> 
> (Updated April 22, 2014, 1:39 p.m.)
> 
> 
> Review request for KDE Frameworks and Chusslove Illich.
> 
> 
> Repository: ki18n
> 
> 
> Description
> -------
> 
> Even if an application has not been translated, the libraries it uses might be. It makes sense in this case to load those translations. This is especially useful for small test programs.
> 
> 
> Diffs
> -----
> 
>   src/klocalizedstring.cpp 43e10ab 
> 
> Diff: https://git.reviewboard.kde.org/r/117688/diff/
> 
> 
> Testing
> -------
> 
> - Built the kiconthemes framework with translation support (adding -DTRANSLATION_DOMAIN=\"kiconthemes5\" definition)
> - Created and installed a French translation for it.
> - Ran kicondialogtest: with the patch the dialog is translated, without the patch it is not.
> 
> 
> Thanks,
> 
> Aurélien Gâteau
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140426/36377bcd/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list