Review Request 117475: kmimeassociationstest: do not use KDE apps in test

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117475/#review56503
-----------------------------------------------------------


This review has been submitted with commit 9e9982ad008596916fdbf8e9e5520f03385f37c0 by Alex Merry to branch master.

- Commit Hook


On April 24, 2014, 6:54 p.m., Alex Merry wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117475/
> -----------------------------------------------------------
> 
> (Updated April 24, 2014, 6:54 p.m.)
> 
> 
> Review request for KDE Frameworks and David Faure.
> 
> 
> Repository: kservice
> 
> 
> Description
> -------
> 
> kmimeassociationstest: do not use KDE apps in test
> 
> Looking for applications with a kde4- prefix will not be useful in the
> long term, as those applications will disappear as people move away from
> kdelibs4. However, simply stripping the kde4- prefix also does not work
> because you can set a mime type assocation for "kwrite.desktop", and if
> the KF5-based KWrite (which has the desktop ID "kwrite.desktop") is not
> installed but the kdelibs4-based one (which has the desktop ID
> "kde4-kwrite.desktop") is installed, the mime type will be associated
> with kde4-kwrite.desktop, and the test will fail.
> 
> To avoid this issue, we avoid using KDE applications in the tests.
> 
> The prefixing stuff is explicitly tested with some fake application
> desktop files. We still try adding and removing associations for real
> applications (that may or may not be installed) to test cascading.
> 
> 
> Diffs
> -----
> 
>   autotests/kmimeassociationstest.cpp d7b3ac29ca7292c0250286b241f20891c988bab6 
> 
> Diff: https://git.reviewboard.kde.org/r/117475/diff/
> 
> 
> Testing
> -------
> 
> Test still passes.
> 
> 
> Thanks,
> 
> Alex Merry
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140425/fc167f26/attachment.html>