Review Request 117733: Fully port KXMessages to XCB

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117733/#review56449
-----------------------------------------------------------

Ship it!



src/kxmessages.h
<https://git.reviewboard.kde.org/r/117733/#comment39404>

    should say "@deprecated since 5.0"



src/kxmessages.cpp
<https://git.reviewboard.kde.org/r/117733/#comment39405>

    Small issue: this doesn't look sorted by decreasing size. The bools should be last, not sure what's the size of the xcb_*_t types though.


- David Faure


On April 24, 2014, 8:02 a.m., Martin Gräßlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117733/
> -----------------------------------------------------------
> 
> (Updated April 24, 2014, 8:02 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kwindowsystem
> 
> 
> Description
> -------
> 
> Fully port KXMessages to XCB
> 
> * use xcb to resolve the intern atoms
> * use xcb event structure for sending the client message
> * add xcb overload for KXMessages::broadcastMessageX
> * deprecate XLib variant
> * extend test to verify all three variants of sending messages
> 
> 
> Diffs
> -----
> 
>   autotests/kxmessages_unittest.cpp 90900f23961184e6bd35475e2cc43e0caa9099e9 
>   src/kxmessages.h e6534964e82bddae46a7b09976e9b7c9e3138a2a 
>   src/kxmessages.cpp c76de22f5537e8a265d4dce53ce07e90234caeef 
> 
> Diff: https://git.reviewboard.kde.org/r/117733/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140424/5c85c827/attachment.html>