Review Request 117749: Allow kmimeassociationstest to be run alone

David Faure faure at kde.org
Thu Apr 24 22:45:07 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117749/#review56447
-----------------------------------------------------------

Ship it!


Ship It!

- David Faure


On April 24, 2014, 5:37 p.m., Alex Merry wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117749/
> -----------------------------------------------------------
> 
> (Updated April 24, 2014, 5:37 p.m.)
> 
> 
> Review request for KDE Frameworks and David Faure.
> 
> 
> Repository: kservice
> 
> 
> Description
> -------
> 
> Allow kmimeassociationstest to be run alone
> 
> Previously, it tried to create a KServiceFactory without ensuring the
> sycoca database had been created, which caused an assert if it had not.
> It was not caught previously, because "make test" runs other tests first
> that generate the sycoca database.
> 
> 
> Diffs
> -----
> 
>   autotests/kmimeassociationstest.cpp d7b3ac29ca7292c0250286b241f20891c988bab6 
> 
> Diff: https://git.reviewboard.kde.org/r/117749/diff/
> 
> 
> Testing
> -------
> 
> rm -rf ~/.qttest
> Ran kmimeassociationstest directly.
> It passes.
> 
> 
> Thanks,
> 
> Alex Merry
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140424/ea6cd47c/attachment.html>


More information about the Kde-frameworks-devel mailing list