Review Request 117703: Use NETWinInfo instead of custom XLib code in KStartupInfo

Kevin Ottens ervin at kde.org
Thu Apr 24 22:37:43 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117703/#review56442
-----------------------------------------------------------

Ship it!


Ship It!

- Kevin Ottens


On April 23, 2014, 11:58 a.m., Martin Gräßlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117703/
> -----------------------------------------------------------
> 
> (Updated April 23, 2014, 11:58 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kwindowsystem
> 
> 
> Description
> -------
> 
> Use NETWinInfo instead of custom XLib code in KStartupInfo
> 
> KStartupInfo had quite a lot of XLib code to read/write properties which
> are also abstracted by NETWinInfo. This makes the code less dependend on
> XLib and hopefully easier to read.
> 
> 
> Diffs
> -----
> 
>   src/kstartupinfo.cpp 6a95ce2d2eb79abbfbd072fa922f458da30d37eb 
> 
> Diff: https://git.reviewboard.kde.org/r/117703/diff/
> 
> 
> Testing
> -------
> 
> Run the unit tests.
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140424/a7a4cf08/attachment.html>


More information about the Kde-frameworks-devel mailing list