Review Request 117688: Do not skip a language if there is no application catalog for it

[Chusslove Illich]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117688/#review56183
-----------------------------------------------------------


This language skipping was originally motivated precisely because some people thought it bad to have apparent partial translation of an application. I can't point to exact discussion, it was before "my time". But therefore I wouldn't change it now without special discussion. If translation is wanted in a small test program, it could set "ki18n5" for application catalog.


- Chusslove Illich


On April 22, 2014, 3:39 p.m., Aurélien Gâteau wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117688/
> -----------------------------------------------------------
> 
> (Updated April 22, 2014, 3:39 p.m.)
> 
> 
> Review request for KDE Frameworks and Chusslove Illich.
> 
> 
> Repository: ki18n
> 
> 
> Description
> -------
> 
> Even if an application has not been translated, the libraries it uses might be. It makes sense in this case to load those translations. This is especially useful for small test programs.
> 
> 
> Diffs
> -----
> 
>   src/klocalizedstring.cpp 43e10ab 
> 
> Diff: https://git.reviewboard.kde.org/r/117688/diff/
> 
> 
> Testing
> -------
> 
> - Built the kiconthemes framework with translation support (adding -DTRANSLATION_DOMAIN=\"kiconthemes5\" definition)
> - Created and installed a French translation for it.
> - Ran kicondialogtest: with the patch the dialog is translated, without the patch it is not.
> 
> 
> Thanks,
> 
> Aurélien Gâteau
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140422/42df6a08/attachment.html>