Review Request 117511: Add class for finding the kde4 config and apps home dirs.

[Kevin Krammer]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117511/#review56172
-----------------------------------------------------------



src/lib/util/kdelibs4migration.cpp
<https://git.reviewboard.kde.org/r/117511/#comment39207>

    would QStringLiteral work here?



src/lib/util/kdelibs4migration.cpp
<https://git.reviewboard.kde.org/r/117511/#comment39204>

    Hmm. I think that looks weird.
    Can this be split in the type definition (struct something) and the constant defintion?



src/lib/util/kdelibs4migration.cpp
<https://git.reviewboard.kde.org/r/117511/#comment39205>

    Also maybe just a personal taste, but I find it better to explicitly use parentheses when mixing boolean and arithmetic operators, i.e. make it explicit which operator has precendence. In this case putting parentheses around the size calculation.
    Or even calculating the size as a const int before the loop (can it be done as a const_expr outside the function?).
    



src/lib/util/kdelibs4migration.cpp
<https://git.reviewboard.kde.org/r/117511/#comment39208>

    Do we have some logging categories for kdecoreaddons?


- Kevin Krammer


On April 22, 2014, 9:32 a.m., David Faure wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117511/
> -----------------------------------------------------------
> 
> (Updated April 22, 2014, 9:32 a.m.)
> 
> 
> Review request for KDE Frameworks, Ivan Čukić and Kevin Krammer.
> 
> 
> Repository: kcoreaddons
> 
> 
> Description
> -------
> 
> Add class for finding the kde4 config and apps home dirs.
> 
> To help applications migrating to the kf5/qt5 directories.
> 
> 
> Diffs
> -----
> 
>   autotests/CMakeLists.txt 2f14b3a229b07071ed6e8b0772e03ee798db6c03 
>   autotests/kdelibs4migrationtest.cpp PRE-CREATION 
>   src/lib/CMakeLists.txt 39ca3b8e9d5a4f8ffa06ca2ccf017b02ac245fd7 
>   src/lib/util/kdelibs4migration.h PRE-CREATION 
>   src/lib/util/kdelibs4migration.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/117511/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Faure
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140422/d87f8d9b/attachment.html>