Remnants of monolithic kdelibs.git building

Nicolás Alvarez nicolas.alvarez at gmail.com
Mon Apr 21 19:53:37 UTC 2014


2014-03-27 13:18 GMT-03:00 Alex Merry <alex.merry at kde.org>:
> On 27/03/14 15:39, Nicolás Alvarez wrote:
>> Many frameworks' top-level CMakeLists.txt still wrap their
>> find_package calls in:
>>
>> if ("${CMAKE_BINARY_DIR}" STREQUAL "${CMAKE_CURRENT_BINARY_DIR}")
>>
>> That's left over from when the frameworks had to build both standalone
>> and as part of the large kdelibs.git repository. Should it be removed?
>>
>
> Yes.  Quite a lot of them have already been cleaned up, but the rest
> should be done as well.

I cleaned up a few (while bored waiting for other stuff to finish
compiling). Still not done.

-- 
Nicolás


More information about the Kde-frameworks-devel mailing list