Review Request 117582: Simplify D-Bus service CMake code

[Alex Merry]

> On April 21, 2014, 4:51 p.m., David Faure wrote:
> > Ah, OK. I like to make things easy and high-level to simplify maintenance, but OK :)

In general, I agree, but my view is that this macro heads into the "dark magic" area where it's very easy to screw it up, and this seems silly for something so simple. In order to use it you have to know it behaves like configure_file() (because you have to construct the file yourself), except that it also installs it somewhere (for which you have to make sure DBUS_SERVICES_INSTALL_DIR is defined before you use it, which is certainly not a given for non-KDE projects). By this point, why not just use configure_file() and install()? The DBUS_SERVICES_INSTALL_DIR provided by KDEInstallDirs is all the magic you actually need, and if that's explicit in the CMakeLists.txt file, it's a lot more obvious that you should have it defined somewhere.


- Alex


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117582/#review56129
-----------------------------------------------------------


On April 16, 2014, 10:23 a.m., Alex Merry wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117582/
> -----------------------------------------------------------
> 
> (Updated April 16, 2014, 10:23 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kded
> 
> 
> Description
> -------
> 
> Simplify D-Bus service CMake code
> 
> 
> Diffs
> -----
> 
>   src/CMakeLists.txt 8d5ec90a56d48d6be8f126cc5b228a5f965386b6 
> 
> Diff: https://git.reviewboard.kde.org/r/117582/diff/
> 
> 
> Testing
> -------
> 
> Configured, built, installed.  Installation step reported that "/home/kf5-devel/kf5/share/dbus-1/services/org.kde.kded5.service" was "Up-to-date".
> 
> 
> Thanks,
> 
> Alex Merry
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140421/8c05df7d/attachment.html>