Review Request 117582: Simplify D-Bus service CMake code

[Alex Merry]

> On April 21, 2014, 3:12 p.m., David Faure wrote:
> > This macro was upstreamed into ECM as modules/ECMDBusAddActivationService.cmake, why not port the code to that?

Because I want to remove that from ECM (or at least deprecate it), as I consider it pointless. All it does is obfuscate two lines of code - configure_file() and install().

See https://git.reviewboard.kde.org/r/117581/ (although aacid is pushing for just removing it altogether).


- Alex


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117582/#review56125
-----------------------------------------------------------


On April 16, 2014, 10:23 a.m., Alex Merry wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117582/
> -----------------------------------------------------------
> 
> (Updated April 16, 2014, 10:23 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kded
> 
> 
> Description
> -------
> 
> Simplify D-Bus service CMake code
> 
> 
> Diffs
> -----
> 
>   src/CMakeLists.txt 8d5ec90a56d48d6be8f126cc5b228a5f965386b6 
> 
> Diff: https://git.reviewboard.kde.org/r/117582/diff/
> 
> 
> Testing
> -------
> 
> Configured, built, installed.  Installation step reported that "/home/kf5-devel/kf5/share/dbus-1/services/org.kde.kded5.service" was "Up-to-date".
> 
> 
> Thanks,
> 
> Alex Merry
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140421/aeb65f76/attachment.html>