Review Request 117654: Replace range-based for loop with Qt foreach

David Faure faure at kde.org
Mon Apr 21 15:01:02 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117654/#review56123
-----------------------------------------------------------

Ship it!


Ship It!

- David Faure


On April 20, 2014, 2:55 a.m., Nicolás Alvarez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117654/
> -----------------------------------------------------------
> 
> (Updated April 20, 2014, 2:55 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kwallet
> 
> 
> Description
> -------
> 
> MSVC2010 (our minimum requirement for KF5) doesn't support range-for loops; replace with Qt foreach().
> 
> 
> Diffs
> -----
> 
>   src/runtime/kwalletd/kwalletd.cpp 7a40b63 
> 
> Diff: https://git.reviewboard.kde.org/r/117654/diff/
> 
> 
> Testing
> -------
> 
> All of KWallet builds on Windows with MSVC2010 (if review #117652 is applied too).
> 
> 
> Thanks,
> 
> Nicolás Alvarez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140421/ce5a1eee/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list