Review Request 117578: Use "ThumbCreator" instead of "KFilePlugin" when querying for thumbnails services

[Martin Klapetek]

> On April 18, 2014, 5:15 p.m., Alex Merry wrote:
> > I don't think this is the right fix.  ThumbCreator is what the thumbnailer is *providing*, while this block is seeing if it can use an already-existing thumbnailer from the metadata (I think it's supposed to be something extracted by strigi).
> > 
> > In fact, I suspect that entire block should go - KFileMetaInfo is in KDELibs4Support.

Ah, you are quite possibly correct, the ThumbCreator is created a bit further down. I'll discard this then.


- Martin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117578/#review56027
-----------------------------------------------------------


On April 15, 2014, 9:45 p.m., Martin Klapetek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117578/
> -----------------------------------------------------------
> 
> (Updated April 15, 2014, 9:45 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kio-extras
> 
> 
> Description
> -------
> 
> Plasma-shell outputs an error "cannot find KFilePlugin service, make sure the desktop file is installed". I looked at the imagethumbnail.desktop (and others) and it uses "ThumbCreator". Replacing KFilePlugin with ThumbCreator fixes that warning.
> 
> 
> Diffs
> -----
> 
>   thumbnail/thumbnail.cpp c9eebe7 
> 
> Diff: https://git.reviewboard.kde.org/r/117578/diff/
> 
> 
> Testing
> -------
> 
> Plasma no longer prints and error.
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140418/66d4ab68/attachment-0001.html>