Review Request 117599: Improve tests

Aleix Pol Gonzalez aleixpol at kde.org
Wed Apr 16 22:21:40 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117599/#review55922
-----------------------------------------------------------

Ship it!


Looks good, interesting work towards a more unified experience across frameworks.

- Aleix Pol Gonzalez


On April 16, 2014, 4:53 p.m., Michael Palimaka wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117599/
> -----------------------------------------------------------
> 
> (Updated April 16, 2014, 4:53 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> Move some stray tests to the root directory in line with other tests.
> 
> 
> Diffs
> -----
> 
>   src/plasmaquick/autotests/CMakeLists.txt 9a54d186359729fe37d0fe03c7faee1e478bf3af 
>   src/plasmaquick/CMakeLists.txt 0b43f9156f3b4c32ad0a7f9a1ffcb55ff29e1a9c 
>   src/declarativeimports/core/tests/sortfiltermodeltest.h  
>   src/declarativeimports/core/tests/sortfiltermodeltest.cpp f4f930c2ec3abffed4773e6f2340693117426dd5 
>   src/declarativeimports/core/tests/modeltest.cpp  
>   src/declarativeimports/core/tests/modeltest.h  
>   src/declarativeimports/core/tests/manual/dialog_positioning.qml  
>   src/declarativeimports/core/tests/dynamictreemodel.cpp  
>   src/declarativeimports/core/tests/dynamictreemodel.h  
>   src/declarativeimports/core/tests/CMakeLists.txt 9fc9f894a4b8131f5870a839e892de6cf6e9026e 
>   src/declarativeimports/core/CMakeLists.txt 044e043cf980d54448495dbe4450b892907ecf39 
>   autotests/CMakeLists.txt e5db1c5290f421da4606c9a0a0bc673fe61f94da 
>   CMakeLists.txt 3052efc471cfd6518f0c82148eb08409da56b6bf 
>   src/plasmaquick/autotests/packageurlinterceptortest.h  
>   src/plasmaquick/autotests/packageurlinterceptortest.cpp d39a89aaba811b1ab1045be2b5dbe0d279a39235 
> 
> Diff: https://git.reviewboard.kde.org/r/117599/diff/
> 
> 
> Testing
> -------
> 
> Builds, tests still pass.
> 
> 
> Thanks,
> 
> Michael Palimaka
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140416/7a6d3f6b/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list