Review Request 117604: Fix KDBusServiceStarter::findServiceFor() not returning error string

[Aleix Pol Gonzalez]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117604/#review55921
-----------------------------------------------------------



src/plugin/kdbusservicestarter.cpp
<https://git.reviewboard.kde.org/r/117604/#comment38944>

    It should be a qWarning.


Looks good to me though, it's very annoying to debug this kind of problems without feedback. +1

- Aleix Pol Gonzalez


On April 16, 2014, 9:07 p.m., David Jarvie wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117604/
> -----------------------------------------------------------
> 
> (Updated April 16, 2014, 9:07 p.m.)
> 
> 
> Review request for KDE Frameworks and David Faure.
> 
> 
> Repository: kservice
> 
> 
> Description
> -------
> 
> When KDBusServiceStarter::findServiceFor() fails to start the requested service after it is found to not be running, it does not return the error string. This patch fixes that and makes it behave as in the apidox.
> 
> This is a copy of https://git.reviewboard.kde.org/r/116951/ for KDE 4, except that the qDebug line has been uncommented on the grounds that it reports an error.
> 
> 
> Diffs
> -----
> 
>   src/plugin/kdbusservicestarter.cpp 6f011bd 
> 
> Diff: https://git.reviewboard.kde.org/r/117604/diff/
> 
> 
> Testing
> -------
> 
> Tested for review 116951.
> 
> 
> Thanks,
> 
> David Jarvie
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140416/2fddf9e2/attachment.html>