Review Request 117511: Add class for finding the kde4 config and apps home dirs.

[Kevin Ottens]

> On April 12, 2014, 11:12 a.m., Kevin Krammer wrote:
> > I wonder if this really belongs in kdecoreaddons. I.e. it is only relevant for KDE applications porting, right?
> > IMHO this would fit best in an explicit porting framework
> 
> David Faure wrote:
>     I don't want to put this in kdelibs4support because apps are supposed to port away from that and stop linking to it (thus avoiding "I link to everything"),
>     while they are supposed to keep the migration code for quite some time (not everyone will upgrade to 5.0 right away).
>     
>     I don't think it makes sense to create yet another framework for one class. We are going crazy already with the number of frameworks and the small size of some of them.
>     
>     So this leaves.... kcoreaddons, unless you have a better suggestion.
>

If that's really only about configuration, why not kconfig? That's where we have the config update tooling too. I'd find it less surprising there. If not strictly about configuration kcoreaddons seems the only sane option indeed.


> On April 12, 2014, 11:12 a.m., Kevin Krammer wrote:
> > src/lib/util/kdelibs4migration.cpp, line 26
> > <https://git.reviewboard.kde.org/r/117511/diff/1/?file=264937#file264937line26>
> >
> >     initialize d to nullptr?

I'd go further and say: why not use the d pointer even today.


- Kevin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117511/#review55504
-----------------------------------------------------------


On April 12, 2014, 11:01 a.m., David Faure wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117511/
> -----------------------------------------------------------
> 
> (Updated April 12, 2014, 11:01 a.m.)
> 
> 
> Review request for KDE Frameworks, Ivan Čukić and Kevin Krammer.
> 
> 
> Repository: kcoreaddons
> 
> 
> Description
> -------
> 
> Add class for finding the kde4 config and apps home dirs.
> 
> To help applications migrating to the kf5/qt5 directories.
> 
> 
> Diffs
> -----
> 
>   autotests/CMakeLists.txt 7ab7bc43be1434ae93f7c77af90e41bbde5168ac 
>   autotests/kdelibs4migrationtest.cpp PRE-CREATION 
>   src/lib/CMakeLists.txt 1d17874f0da428bd34ea85ee98683f6fef620c81 
>   src/lib/util/kdelibs4migration.h PRE-CREATION 
>   src/lib/util/kdelibs4migration.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/117511/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Faure
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140414/5b660cb7/attachment.html>